Fix ReindexDataStreamIndexAction timestamp validation bug in tests #122274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkertimmins
added
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
parkertimmins
changed the title
parkertimmins
added
the
auto-backport
parkertimmins
deleted the
reindex-data-stream-fix-pipeline-second-try
branch
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Feb 12, 2025
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lastic#122274) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry.
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lastic#122274) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry. (cherry picked from commit 05a2003) # Conflicts: # muted-tests.yml # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 12, 2025
…lastic#122274) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry. (cherry picked from commit 05a2003) # Conflicts: # muted-tests.yml # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…122274) (#122384) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…sts (#122274) (#122382) * Fix ReindexDataStreamIndexAction timestamp validation bug in tests (#122274) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry. (cherry picked from commit 05a2003) # Conflicts: # muted-tests.yml # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java * getPipelines missing from 8x.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ests (#122274) (#122385) * Fix ReindexDataStreamIndexAction timestamp validation bug in tests (#122274) Fix race condition test bugs related to the reindex-data-stream-pipeline. For tests that add doc without timestamp, then add mapping with timestamp, ensure green between adding doc and adding mapping. This makes sure that doc has been written to all shards and thus that timestamp validation does not occur while doc is being written to a shard. Delete pipeline in Before method, then wait for it to be re-created by the MigrateTemplateRegistry. (cherry picked from commit 05a2003) # Conflicts: # muted-tests.yml # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java * getPipelines missing from 8.18
This was referenced Feb 13, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failures of the form
All incoming requests on node [node_s1] should have finished. Expected 0 bytes for requests in-flight but got 298 bytes. A couple of fixes:@Before, then wait for it to be re-created by the MigrateTemplateRegistry